This repository has been archived by the owner on May 15, 2024. It is now read-only.
GH-8: Add Connectivity API #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #8 |
jamesmontemagno
changed the title
jamesmontemagno
changed the title
jamesmontemagno
changed the title
Ensures that when profiles change an event is triggered.
Local functions!!!!!!!!
jamesmontemagno
changed the title
jamesmontemagno
added
awaiting-review
|
build |
Redth
reviewed
Mar 26, 2018
| var currentAccess = NetworkAccess.None; | ||
| var manager = Platform.ConnectivityManager; | ||
|
|
||
| if (Build.VERSION.SdkInt >= BuildVersionCodes.Lollipop) |
There was a problem hiding this comment.
Use the new platform.hasapi here?
Redth
reviewed
Mar 26, 2018
| { | ||
| ValidatePermission(); | ||
| var manager = Platform.ConnectivityManager; | ||
| if (Build.VERSION.SdkInt >= BuildVersionCodes.Lollipop) |
Redth
reviewed
Mar 26, 2018
| { | ||
| get | ||
| { | ||
| ValidatePermission(); |
There was a problem hiding this comment.
Are we ok with potentially throwing here?
There was a problem hiding this comment.
Agreed that we are only because it is a manifest check :)
Redth
approved these changes
Mar 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist