Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Fixes hang waiting for cancelled TextToSpeech #1895

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Fixes hang waiting for cancelled TextToSpeech #1895

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
987109f
Create the TaskCompletionSource before registering for cancellation
borigas Oct 6, 2021
8b83bf9
Merge branch 'main' into TextToSpeechCancelHang
jfversluis Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Xamarin.Essentials/TextToSpeech/TextToSpeech.android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ public async Task SpeakAsync(string text, int max, SpeechOptions options, Cancel
if (tcsUtterances?.Task != null)
await tcsUtterances.Task;

tcsUtterances = new TaskCompletionSource<bool>();

if (cancelToken != null)
{
cancelToken.Register(() =>
Expand Down Expand Up @@ -150,7 +152,6 @@ public async Task SpeakAsync(string text, int max, SpeechOptions options, Cancel
var parts = text.SplitSpeak(max);

numExpectedUtterances = parts.Count;
tcsUtterances = new TaskCompletionSource<bool>();

var guid = Guid.NewGuid().ToString();

Expand Down