Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Rebranding to Xamarin.Essentials #152

Merged
merged 1 commit into from
Apr 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ Describe any non-bug related behavioral changes that may change how users app be
- [ ] Has samples (if omitted, state reason in description)
- [ ] Rebased on top of master at time of PR
- [ ] Changes adhere to coding standard
- [ ] Updated documentation ([see walkthrough](https://github.com/xamarin/Caboodle/wiki/Documenting-your-code-with-mdoc))
- [ ] Updated documentation ([see walkthrough](https://github.com/xamarin/Xamarin.Essentials/wiki/Documenting-your-code-with-mdoc))
24 changes: 12 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Contributing

Thanks you for your interest in contributing to Microsoft Caboodle! In this document we'll outline what you need to know about contributing and how to get started.
Thanks you for your interest in contributing to Xamarin.Essentials! In this document we'll outline what you need to know about contributing and how to get started.

## Code of Conduct

Expand All @@ -12,7 +12,7 @@ You will need to complete a Contribution License Agreement before any pull reque

## Contributing Code

Check out [A Beginner's Guide for Contributing to Microsoft Caboodle](https://github.com/xamarin/Caboodle/wiki/A-Beginner's-Guide-for-Contributing-to-Microsoft-Caboodle).
Check out [A Beginner's Guide for Contributing to Xamarin.Essentials](https://github.com/xamarin/Xamarin.Essentials/wiki/A-Beginner's-Guide-for-Contributing-to-Xamarin.Essentials).

## Documentation - mdoc

Expand All @@ -25,48 +25,48 @@ Every pull request which affects public types or members should include correspo

### Bug Fixes

If you're looking for something to fix, please browse [open issues](https://github.com/xamarin/Caboodle/issues).
If you're looking for something to fix, please browse [open issues](https://github.com/xamarin/Xamarin.Essentials/issues).

Follow the style used by the [.NET Foundation](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md), with two primary exceptions:

- We do not use the `private` keyword as it is the default accessibility level in C#.
- We will **not** use `_` or `s_` as a prefix for internal or private field names
- We will use `camelCaseFieldName` for naming internal or private fields in both instance and static implementations

Read and follow our [Pull Request template](https://github.com/xamarin/Caboodle/blob/master/PULL_REQUEST_TEMPLATE.md)
Read and follow our [Pull Request template](https://github.com/xamarin/Xamarin.Essentials/blob/master/PULL_REQUEST_TEMPLATE.md)

### Proposals

To propose a change or new feature, review the guidance below and then [open an issue using this template](https://github.com/xamarin/Caboodle/issues/new).
To propose a change or new feature, review the guidance below and then [open an issue using this template](https://github.com/xamarin/Xamarin.Essentials/issues/new).

#### Non-Starter Topics
The following topics should generally not be proposed for discussion as they are non-starters:

* Large renames of APIs
* Large non-backward-compatible breaking changes
* Platform-Specifics which can be accomplished without changing Microsoft Caboodle
* Platform-Specifics which can be accomplished without changing Xamarin.Essentials
* Avoid clutter posts like "+1" which do not serve to further the conversation

#### Proposal States
##### Open
Open proposals are still under discussion. Please leave your concrete, constructive feedback on this proposal. +1s and other clutter posts which do not add to the discussion will be removed.

##### Accepted
Accepted proposals are proposals that both the community and core Microsoft Caboodle agree should be a part of Microsoft Caboodle. These proposals are ready for implementation, but do not yet have a developer actively working on them. These proposals are available for anyone to work on, both community and the core Microsoft Caboodle team.
Accepted proposals are proposals that both the community and core Xamarin.Essentials agree should be a part of Xamarin.Essentials. These proposals are ready for implementation, but do not yet have a developer actively working on them. These proposals are available for anyone to work on, both community and the core Xamarin.Essentials team.

If you wish to start working on an accepted proposal, please reply to the thread so we can mark you as the implementor and change the title to In Progress. This helps to avoid multiple people working on the same thing. If you decide to work on this proposal publicly, feel free to post a link to the branch as well for folks to follow along.

###### What "Accepted" does mean
* Any community member is welcome to work on the idea.
* The core Microsoft Caboodle team _may_ consider working on this idea on their own, but has not done so until it is marked "In Progress" with a team member assigned as the implementor.
* The core Xamarin.Essentials team _may_ consider working on this idea on their own, but has not done so until it is marked "In Progress" with a team member assigned as the implementor.
* Any pull request implementing the proposal will be welcomed with an API and code review.

###### What "Accepted" does not mean
* The proposal will ever be implemented, either by a community member or by the core Microsoft Caboodle team.
* The core Microsoft Caboodle team is committing to implementing a proposal, even if nobody else does. Accepted proposals simply mean that the core Microsoft Caboodle team and the community agree that this proposal should be a part of Microsoft Caboodle.
* The proposal will ever be implemented, either by a community member or by the core Xamarin.Essentials team.
* The core Xamarin.Essentials team is committing to implementing a proposal, even if nobody else does. Accepted proposals simply mean that the core Xamarin.Essentials team and the community agree that this proposal should be a part of Xamarin.Essentials.

##### In Progress
Once a developer has begun work on a proposal, either from the core Microsoft Caboodle team or a community member, the proposal is marked as in progress with the implementors name and (possibly) a link to a development branch to follow along with progress.
Once a developer has begun work on a proposal, either from the core Xamarin.Essentials team or a community member, the proposal is marked as in progress with the implementors name and (possibly) a link to a development branch to follow along with progress.

#### Rejected
Rejected proposals will not be implemented or merged into Microsoft Caboodle. Once a proposal is rejected, the thread will be closed and the conversation is considered completed, pending considerable new information or changes.
Rejected proposals will not be implemented or merged into Xamarin.Essentials. Once a proposal is rejected, the thread will be closed and the conversation is considered completed, pending considerable new information or changes.
4 changes: 2 additions & 2 deletions Caboodle.Tests/Acceleromter_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class Accelerometer_Tests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/Battery_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class Battery_Tests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/Browser_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
using System;
using System.Threading.Tasks;
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class BrowserTests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/Clipboard_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using System.Threading.Tasks;
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class Clipboard_Tests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/Compass_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using System;
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class Compass_Tests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/Connectivity_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class Connectivity_Tests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/DataTransfer_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using System.Threading.Tasks;
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class DataTransfer_Tests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/Email_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class Email_Tests
{
Expand Down
2 changes: 1 addition & 1 deletion Caboodle.Tests/FileSystem_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System.Threading.Tasks;
using Xunit;

namespace Microsoft.Caboodle.Tests
namespace Tests
{
public class FileSystem_Tests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/Geocoding_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using System.Threading.Tasks;
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class Geocoding_Tests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/Gyroscope_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class Gyroscope_Tests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/Magnetometer_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class Magnetometer_Tests
{
Expand Down
4 changes: 2 additions & 2 deletions Caboodle.Tests/PhoneDialer_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Microsoft.Caboodle;
using Xamarin.Essentials;
using Xunit;

namespace Caboodle.Tests
namespace Tests
{
public class PhoneDialer_Tests
{
Expand Down
2 changes: 1 addition & 1 deletion Caboodle.Tests/Preferences_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using Xunit;

namespace Microsoft.Caboodle.Tests
namespace Tests
{
public class Preferences_Tests
{
Expand Down
2 changes: 1 addition & 1 deletion Caboodle.Tests/SecureStorage_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System.Threading.Tasks;
using Xunit;

namespace Microsoft.Caboodle.Tests
namespace Tests
{
public class SecureStorage_Tests
{
Expand Down
2 changes: 1 addition & 1 deletion Caboodle.Tests/Sms_Tests.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System.Threading.Tasks;
using Xunit;

namespace Microsoft.Caboodle.Tests
namespace Tests
{
public class Sms_Tests
{
Expand Down
30 changes: 15 additions & 15 deletions Caboodle.sln
Original file line number Diff line number Diff line change
Expand Up @@ -7,43 +7,43 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
ProjectSection(SolutionItems) = preProject
.editorconfig = .editorconfig
.gitignore = .gitignore
Caboodle.ruleset = Caboodle.ruleset
Xamarin.Essentials.ruleset = Xamarin.Essentials.ruleset
README.md = README.md
stylecop.json = stylecop.json
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Tests", "Tests", "{A14D061F-382D-4609-A3B0-E1D0BF7AB6AC}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Caboodle", "Caboodle\Caboodle.csproj", "{63A4F6A1-48BF-4D32-AED7-82F605EDB042}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Xamarin.Essentials", "Xamarin.Essentials\Xamarin.Essentials.csproj", "{63A4F6A1-48BF-4D32-AED7-82F605EDB042}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Caboodle.Tests", "Caboodle.Tests\Caboodle.Tests.csproj", "{77C2F93D-6EB7-49F7-A74A-C80499EC206A}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tests", "Tests\Tests.csproj", "{77C2F93D-6EB7-49F7-A74A-C80499EC206A}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Samples", "Samples", "{706C0487-6930-4E55-8720-C17D9FE6CA91}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Caboodle.Samples", "Samples\Caboodle.Samples\Caboodle.Samples.csproj", "{2550ED91-8AE1-4E9A-A964-C11515C8FA28}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Samples", "Samples\Samples\Samples.csproj", "{2550ED91-8AE1-4E9A-A964-C11515C8FA28}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Caboodle.Samples.Android", "Samples\Caboodle.Samples.Android\Caboodle.Samples.Android.csproj", "{C1CD30D3-52CA-4F8E-8499-BE88567CA2F8}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Samples.Android", "Samples\Samples.Android\Samples.Android.csproj", "{C1CD30D3-52CA-4F8E-8499-BE88567CA2F8}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Caboodle.Samples.iOS", "Samples\Caboodle.Samples.iOS\Caboodle.Samples.iOS.csproj", "{E2571C97-C048-4F91-8BB3-546CF7410C4C}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Samples.iOS", "Samples\Samples.iOS\Samples.iOS.csproj", "{E2571C97-C048-4F91-8BB3-546CF7410C4C}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Caboodle.Samples.UWP", "Samples\Caboodle.Samples.UWP\Caboodle.Samples.UWP.csproj", "{A0798FC9-AB9D-4CCA-AF44-71B7A4691D5A}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Samples.UWP", "Samples\Samples.UWP\Samples.UWP.csproj", "{A0798FC9-AB9D-4CCA-AF44-71B7A4691D5A}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "DeviceTests", "DeviceTests", "{EA9AC363-45BC-4959-BD17-FE3A1B724529}"
EndProject
Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "Caboodle.DeviceTests.Shared", "DeviceTests\Caboodle.DeviceTests.Shared\Caboodle.DeviceTests.Shared.shproj", "{BE0DE9A3-D92C-47C5-9EC4-DFB546BBDF77}"
Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "DeviceTests.Shared", "DeviceTests\DeviceTests.Shared\DeviceTests.Shared.shproj", "{BE0DE9A3-D92C-47C5-9EC4-DFB546BBDF77}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Caboodle.DeviceTests.Android", "DeviceTests\Caboodle.DeviceTests.Android\Caboodle.DeviceTests.Android.csproj", "{CB2072E0-A437-4811-AE17-16CAE0DDA1B1}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DeviceTests.Android", "DeviceTests\DeviceTests.Android\DeviceTests.Android.csproj", "{CB2072E0-A437-4811-AE17-16CAE0DDA1B1}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Caboodle.DeviceTests.iOS", "DeviceTests\Caboodle.DeviceTests.iOS\Caboodle.DeviceTests.iOS.csproj", "{EE8FC716-27FC-405B-BD27-AF17E01A6671}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DeviceTests.iOS", "DeviceTests\DeviceTests.iOS\DeviceTests.iOS.csproj", "{EE8FC716-27FC-405B-BD27-AF17E01A6671}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Caboodle.DeviceTests.UWP", "DeviceTests\Caboodle.DeviceTests.UWP\Caboodle.DeviceTests.UWP.csproj", "{4BD0D88F-7E7A-4C3B-9E34-BF3717A8FF4B}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DeviceTests.UWP", "DeviceTests\DeviceTests.UWP\DeviceTests.UWP.csproj", "{4BD0D88F-7E7A-4C3B-9E34-BF3717A8FF4B}"
EndProject
Global
GlobalSection(SharedMSBuildProjectFiles) = preSolution
DeviceTests\Caboodle.DeviceTests.Shared\Caboodle.DeviceTests.Shared.projitems*{4bd0d88f-7e7a-4c3b-9e34-bf3717a8ff4b}*SharedItemsImports = 4
DeviceTests\Caboodle.DeviceTests.Shared\Caboodle.DeviceTests.Shared.projitems*{be0de9a3-d92c-47c5-9ec4-dfb546bbdf77}*SharedItemsImports = 13
DeviceTests\Caboodle.DeviceTests.Shared\Caboodle.DeviceTests.Shared.projitems*{cb2072e0-a437-4811-ae17-16cae0dda1b1}*SharedItemsImports = 4
DeviceTests\Caboodle.DeviceTests.Shared\Caboodle.DeviceTests.Shared.projitems*{ee8fc716-27fc-405b-bd27-af17e01a6671}*SharedItemsImports = 4
DeviceTests\DeviceTests.Shared\DeviceTests.Shared.projitems*{4bd0d88f-7e7a-4c3b-9e34-bf3717a8ff4b}*SharedItemsImports = 4
DeviceTests\DeviceTests.Shared\DeviceTests.Shared.projitems*{be0de9a3-d92c-47c5-9ec4-dfb546bbdf77}*SharedItemsImports = 13
DeviceTests\DeviceTests.Shared\DeviceTests.Shared.projitems*{cb2072e0-a437-4811-ae17-16cae0dda1b1}*SharedItemsImports = 4
DeviceTests\DeviceTests.Shared\DeviceTests.Shared.projitems*{ee8fc716-27fc-405b-bd27-af17e01a6671}*SharedItemsImports = 4
EndGlobalSection
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down
47 changes: 0 additions & 47 deletions Caboodle/AppInfo/AppInfo.android.cs

This file was deleted.

8 changes: 4 additions & 4 deletions Caboodle/AssemblyInfo/AssemblyInfo.shared.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System.Runtime.CompilerServices;

[assembly: InternalsVisibleTo("Caboodle.Tests")]
[assembly: InternalsVisibleTo("Caboodle.DeviceTests.Android")]
[assembly: InternalsVisibleTo("Caboodle.DeviceTests.UWP")]
[assembly: InternalsVisibleTo("CaboodleDeviceTestsiOS")]
[assembly: InternalsVisibleTo("Tests")]
[assembly: InternalsVisibleTo("DeviceTests.Android")]
[assembly: InternalsVisibleTo("DeviceTests.UWP")]
[assembly: InternalsVisibleTo("Xamarin.EssentialsDeviceTestsiOS")]
3 changes: 0 additions & 3 deletions Caboodle/NamespaceSummaries.xml

This file was deleted.

2 changes: 1 addition & 1 deletion CodeStyles.targets
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<PropertyGroup>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)Caboodle.ruleset</CodeAnalysisRuleSet>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)Xamarin.Essentials.ruleset</CodeAnalysisRuleSet>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

Expand Down
Loading