This repository has been archived by the owner on May 15, 2024. It is now read-only.
GH-136 Make linker safe! #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
approved these changes
Apr 3, 2018
| #elif __IOS__ | ||
| [Foundation.Preserve(AllMembers = true)] | ||
| #endif | ||
| public struct ScreenMetrics |
There was a problem hiding this comment.
Do we have any idea why this type gets removed if the device info is being used?
There was a problem hiding this comment.
I don't to be honest with you. It is kind of odd because other ones are just fine. I would have contact the linker team i guess. However not too worried about a single struct.
There was a problem hiding this comment.
Maybe it is because it is a struct... the other types are classes.
There was a problem hiding this comment.
it was a class originally, i changed to struct :)
There was a problem hiding this comment.
both had the issue
|
build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Ensure linker safe! Enabled LinkerSafe attributes on iOS/Android. Also updated screenmetrics with a preserve so it doesn't get removed.
Bugs Fixed
API Changes
Made ScreenMetrics a struct to align with other types that we have inside of a class.
Added preserve to it so it works.
Behavioral Changes
Added linker settings for sample projects for better testing.
PR Checklist