Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

GH-145 Adjust Package References for Android #146

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

jamesmontemagno
Copy link
Collaborator

Description of Change

Match Xamarin.Forms for Android NuGet Libraries.
Can no longer use fancy Android 8 Features, so if def them for now.

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

Changed:

  • Vibrate will always fall back to classic.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno added this to the Preview-1 milestone Apr 2, 2018
@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Apr 2, 2018
Copy link
Contributor

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad, but real. 😭

@mattleibow
Copy link
Contributor

We could also include BOTH 7.1 and 8.0... A bit more work, but then we stay perfect.

@jamesmontemagno
Copy link
Collaborator Author

We thought about both 7.1 and 8.0, but they would still technically both need 25.X support libraries for compat reasons with Forms.

@Redth thoughts on doing both 7.1 and 8.0 for API surface?

@Redth
Copy link
Member

Redth commented Apr 2, 2018

technically we could compile against 8.0 still and ship a nuget with 7.1 with the 8.0 compiled dll as long as we did runtime checks around any 8.0 api's used. I'm guessing the /t:Pack won't allow this very easily...

I do not think we should ship multi targeted builds for both 7.1 and 8.0 however.

@jamesmontemagno jamesmontemagno merged commit cc02a16 into master Apr 2, 2018
@mattleibow mattleibow deleted the feature/android-nugets branch April 10, 2018 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting-review This PR needs to have a set of eyes on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants