This repository has been archived by the owner on May 15, 2024. It is now read-only.
GH-143 Change compass to event based. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmontemagno
added
the
awaiting-review
jamesmontemagno
added
DO-NOT-MERGE
jamesmontemagno
added
awaiting-review
Redth
reviewed
Apr 2, 2018
| internal static void PlatformStart(SensorSpeed sensorSpeed, Action<CompassData> handler) | ||
| static SensorListener listener; | ||
| static Sensor magnetometer; | ||
| static Sensor accelerometer; |
There was a problem hiding this comment.
Can we dispose/null these out when they are no longer needed?
There was a problem hiding this comment.
so they are shared system wide and if you dispose them out then they will effect other listeners from my testing :(
There was a problem hiding this comment.
Well actually.... maybe if we only allow one at a time.... let me see here. Will need to see if you can do both compass and others at the same time.
There was a problem hiding this comment.
I guess it could get ugly, but could we track/count the # of listeners we have and dispose if 0?
There was a problem hiding this comment.
What if we use a weak reference? This way we leave it up the Androids?
Redth
approved these changes
Apr 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Makes API for compass event based.
Bugs Fixed
PR Checklist