This repository has been archived by the owner on May 15, 2024. It is now read-only.
DeviceTests: Added Traits to headless runner #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets the Virtual/Physical DeviceType trait we will want to exclude (so it’s the opposite of the currently executing device type).
Redth
changed the title
mattleibow
previously approved these changes
Mar 28, 2018
mattleibow
reviewed
Mar 28, 2018
| @@ -8,6 +11,9 @@ internal static class DeviceTypes | |||
| { | |||
| public const string Physical = "Physical"; | |||
| public const string Virtual = "Virtual"; | |||
|
|
|||
| internal static string ToExclude => | |||
| DeviceInfo.DeviceType == RuntimeDeviceType.Physical ? Virtual : Physical; | |||
There was a problem hiding this comment.
Something about this wording/idea is a bit annoying to my mind, but I can't really think of a better/different way right now.
mattleibow
reviewed
Mar 28, 2018
| { | ||
| var filters = new List<XUnitFilter> | ||
| { | ||
| new XUnitFilter(Traits.DeviceType, Traits.DeviceTypes.ToExclude, true) |
There was a problem hiding this comment.
We may need to address this in future if we ever have to add more filters - maybe find a way to sync them up or something. We just have to remember to do this for each platform project.
There was a problem hiding this comment.
Yeah I suppose we could have a shared helper method to GetSharedFilters()
|
@Redth The style Cop got you! 😉 |
mattleibow
approved these changes
Mar 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds the ability to filter device tests by traits.
For starters, the
DeviceTypetrait is now excluded based on if the test runner is on a physical or virtual device (so if we're running onVirtual, all tests marked with aDeviceTypetrait ofDevicewill be skipped (and vice versa).We can add more traits as needed.
PR Checklist