This repository has been archived by the owner on May 15, 2024. It is now read-only.
[Proposal] Add an API to Track App Versions #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmontemagno
suggested changes
Mar 28, 2018
|
|
||
| static Dictionary<string, List<string>> versionTrail; | ||
|
|
||
| public static void Track() |
There was a problem hiding this comment.
Should this really be required? Couldn't we just make a static constructor that gets called when anyone accesses a method?
I could see people calling IsFirstLaunchEver all the time...
jamesmontemagno
added
in-progress
|
Can you add to readme :) added PR requirements |
jamesmontemagno
previously approved these changes
Apr 3, 2018
jamesmontemagno
added
DO-NOT-MERGE
jamesmontemagno
approved these changes
Apr 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by https://github.com/colbylwilliams/VersionTrackingPlugin
This way there is no need for complex code, just use the Preferences and AppInfo
PR Checklist