Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Cache Android SdkInt at runtime #1184

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Cache Android SdkInt at runtime #1184

merged 4 commits into from
Mar 25, 2020

Conversation

Redth
Copy link
Member

@Redth Redth commented Mar 19, 2020

This should never ever change at runtime, so should be safe to cache.

This should never ever change at runtime, so should be safe to cache.
@Redth Redth added this to the 1.5.2 milestone Mar 19, 2020
Co-Authored-By: Matthew Leibowitz <mattleibow@live.com>
Copy link
Collaborator

@jamesmontemagno jamesmontemagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Could make it public for library creators too?

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Mar 21, 2020
@Redth Redth merged commit 34cc39b into develop Mar 25, 2020
@Redth Redth deleted the android-cache-sdkint branch March 25, 2020 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting-review This PR needs to have a set of eyes on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants