This repository was archived by the owner on Jun 20, 2023. It is now read-only.
28.0.0.1 #144
Merged
28.0.0.1 #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one exists in the vector-drawable build task.
We were using `HttpClient` and calling `.Result` on one of the async methods that uses it which can result in a deadlock and might have been causing random locking in the VS IDE. This switches to using `HttpWebRequest` and all synchronous API's to avoid this possible deadlock. We also control the request timeout and set it to a lower 10 seconds as it's not a critical request we don't want to block the IDE too long.
This should make it easier to order by first package version, then Name to identify the odd version(s) out
This will make the dependency exclude="none" in the nuspec which is not the default (by default build/ is excluded from dependencies which is not good for us)
Sometimes doing incremental builds fail without this parameter set.
Had used Value twice instead of Key for the second part.
mattleibow
approved these changes
Jan 17, 2019
| NeedsLicenseUrl = true, | ||
| ValidateRequireLicenseAcceptance = true, | ||
| ValidPackageNamespace = new [] { "Xamarin", "Mono", "SkiaSharp", "HarfBuzzSharp", "mdoc" }, | ||
| ValidPackageNamespace = new [] { "Xamarin" }, |
There was a problem hiding this comment.
A total non-issue, but maybe it might be better to be more specific? "Xamarin.Android.Support" and "Xamarin.Android.Arch" just to make sure that no mistakes creep in for the first few names.
mattleibow
approved these changes
Jan 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bugfixes:
XamarinAndroidSupportSkipVerifyVersionsto enable skipping task manually if necessaryPrivateAssets="none"which would cause the dependency to not include the fragment package's .targets file frombuild/