This repository was archived by the owner on Jun 20, 2023. It is now read-only.
28.0.0 #136
Merged
28.0.0 #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cake addins version pinnings - API_INFO as variable)
new updated references/dependencies
mfractor folder removed
use local cake.packages.config pin cake 27.0.0
These bindings were moved to https://github.com/xamarin/XamarinComponents/tree/master/Android/ConstraintLayout
# Conflicts: # arch-lifecycle/viewmodel/source/Arch.Lifecycle.ViewModel.csproj # build.cake # build.sh # cake.packages.config # preference-leanback-v17/source/V17-Preference-Leanback.csproj # support-dynamic-animation/source/Additions/Additions.cs
This commit marks a different approach to maintaining the bindings, and now uses a binding generation tool currently called AndroidBinderator. This tool will fetch all the required maven artifact information including dependency chains, binaries, etc, and generate Xamarin.Android binding projects for the maven artifacts based on Razor templates for both the .csproj and .targets files. This also uses new SDK style projects which makes packaging nugets easier, especially for including the correct dependency chains in the nupkg’s (which is automated from the maven repository info). This is a work in progress.
They added a BaseOnOffsetChangedListener and our generator was assigning it Java.Lang.Object instead of AppBarLayout
Some type forwards added are still in the direct child assemblies and don't need to be included here as they will be generated.
GenAPI is super fickle. It doesn't like some trailing slashes in some cases, or ; instead of , as a path separator. Also, looks like the v4 project was missing some expected msbuild properties when invoked from the command line on incremental builds, so hard coded things like the intermediate output path and the v9.0 / monoandroid90 framework version which we'll need to eventually bump (maybe not since there are no more support libs?).
GenAPI is a very brittle tool, especially to have run xplat. Since we don't anticipate doing these typeforwards again as Android Support 28.x is the last support library version that will be released, we are going to just manually commit the generated typeforwards this one time, and make it so that msbuild target won't actually run on build. This resolves some headaches of trying to make something work that won't be needed (at least in the same way) again.
`LookupTableInterpolator` was not marked public but was a base type of some missing interpolator classes (like `FastOutSlowInInterpolator`). Marking it public makes these types bound again. This fixes #127
This one wasn't getting downloaded and picked up for packaging, so it went missing...
Updated to switch to nuget validation
Added nuget validation to the 28.x branch
This one was causing issues in the java callable wrapper being generated since it wasn't being generated with the generic type argument on the java side. Turns out, this might have caused issues in .NET bindings as well, so for now we are safe to remove it as there are still overloads anywhere `BaseOnOffsetChangedListener` is used that accept `OnOffsetChangedListener` and both interfaces contain the same method (as used in practice).
This reverts commit 917f6b7. This typo causes issues with other things already referencing it. We are sticking with the unfortunate typo for now at least. In the future we could consider adding a meta package to fix it up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Support Libraries 28.0.0