Repository navigation
Drop quotes whose quoted author handle matches a muted keyword - #140
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This was referenced Sep 7, 2026
Closed
Closed
Pitchfork-and-Torch
added a commit
to Pitchfork-and-Torch/x-algorithm
that referenced
this pull request
Sep 8, 2026
ViewerMutedKeywordFilter only tokenized tweet_text. Gizmoduck already filled retweeted_screen_name on For You, and Night Owl already sets retweeted_user_id on Latest Following, but neither mute-keyword filter matched the original author handle. A followee retweeting @spamAccount ("hello") still served when the viewer muted the keyword spamaccount. Mention-in-text already drops; mute-by-id is already AuthorSocialgraphFilter (#9). This is the leftover author-of-retweeted edge, twin of quoted-author handle (xai-org#140).
Following already matched quoted tweet text. Mute-by-id of the quoted author is a different sink. A muted keyword that is the quoted author's screen name still served the quote card. Hydrate that handle and match it on Latest Following and For You.
Pitchfork-and-Torch
force-pushed
the
cursor/following-latest-mute-residual-5019
branch
from
September 8, 2026 23:11
6dcbd20 to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
Pitchfork-and-Torch
deleted the
cursor/following-latest-mute-residual-5019
branch
September 18, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
FollowingViewerMutedKeywordFilter already drops when quoted tweet text matches a muted keyword. AuthorSocialgraphFilter already drops when the viewer mutes the quoted author by user id (PR 23). Mute-keyword matching never looked at the quoted author handle.
Gizmoduck already filled author_screen_name and retweeted_screen_name. get_screen_names() omitted quoted_user_id. Latest Following never fetched the quoted handle at all.
A followee quoting @spamAccount with comment "look" and quoted text "hello" still served when the viewer muted the keyword spamaccount. Mention-in-text already drops (test_mention_keyword). Quoted text already drops on Following. This is the leftover author-of-quoted edge.
This is not PR 96 (quote/reply/retweet TEXT). Not PR 23 (mute quoted author by id). Not PR 100 (blocked-by retweeted author). Not PR 108 (Following author blocked-by).
Fix
Hydrate quoted_screen_name from Gizmoduck (Phoenix already had the client; Latest Following gets a quoted-user-only hydrator). Match that handle in FollowingViewerMutedKeywordFilter and ViewerMutedKeywordFilter.
Proof
Tests