Skip to content

Fix Degenerate geometry (generating very stretched triangles) #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r-silveira wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix Degenerate geometry (generating very stretched triangles) #507

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17893f9
fix degenerated faces
Nov 19, 2024
9d54c80
change tests
Nov 19, 2024
4a11262
remove my tests
r-silveira Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions Xbim.Geometry.Engine/XbimOccShape.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,9 @@ namespace Xbim
List<List<int>^>^ tessellations = gcnew List<List<int>^>(faceCount);
bool isPolyhedron = true;
array<bool>^ hasSeams = gcnew array<bool>(faceCount);

bool foundDegenerate = false;

//we check if the shape is a faceted poltgon, i.e. all faces are planar and all edges are linear, if so then we do not need to use OCC meshing which is general purpose and a little slower than LibMesh
for (int f = 1; f <= faceMap.Extent(); f++)
{
Expand Down Expand Up @@ -524,15 +527,25 @@ namespace Xbim
{
array<ContourVertex>^ outerContour = gcnew array<ContourVertex>(numberEdges);
BRepTools_WireExplorer exp(outerWire, face);
for (int j = 0; exp.More(); exp.Next())

int j = 0;
for (j = 0; exp.More(); exp.Next())
{
gp_Pnt p = BRep_Tool::Pnt(exp.CurrentVertex());
outerContour[j].Position.X = p.X();
outerContour[j].Position.Y = p.Y();
outerContour[j].Position.Z = p.Z();
j++;
}
tess->AddContour(outerContour); //the original winding is correct as we have oriented the wire to the face in BRepTools_WireExplorer

if (j == numberEdges)
{
tess->AddContour(outerContour); //the original winding is correct as we have oriented the wire to the face in BRepTools_WireExplorer
}
else
{
foundDegenerate = true;
}
}

}
Expand All @@ -559,6 +572,13 @@ namespace Xbim
}
}
}

if (foundDegenerate)
{
foundDegenerate = false;
continue;
}

tess->Tessellate(Xbim::Tessellator::WindingRule::EvenOdd, Xbim::Tessellator::ElementType::Polygons, 3);
if (tess->ElementCount > 0) //we have some triangles
{
Expand Down