Remove division by zero error #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Please update the commit message, there's a minor typo in the file name |
Contributor
Author
|
Corrected the Typo :) |
Owner
|
Please update the requested reviews too, otherwise looks good to merge. |
AnantStrange
commented
Dec 20, 2023
Contributor
Author
AnantStrange
left a comment
AnantStrange
left a comment
There was a problem hiding this comment.
Review done and ready to be merged.
Owner
|
You are supposed to make the changes requested in the review 😅. As for this one, its "Can you move the checking part under the block at line 282? Otherwise, the checking would be done even if data couldn't be fetched." |
Contributor
Author
|
Alright, Made the changes - Moved the check inside the |
x0rzavi
approved these changes
Dec 20, 2023
| pull_requests_merge_percentage = 0 # You can choose another appropriate value | ||
|
|
||
|
|
||
| if user_stats: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Owner
|
Alright, LGTM. Thank you for your contribution! :) |
Contributor
Author
|
Thank you too, my first pr 😁. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fetch_github_stats.py line 297, if user had 0 pull request, a 0 division error would be thrown.
Placed a Check to set pull_merge_request = 0 if merge_request = 0.