Move govuk-prototype-kit to peerDepenencies
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulrobertlloyd aha! Can you remember which bits of the prototype kit this repo even depends on? Given we also use it within Eleventy sites, maybe it could be not needed at all? 🤔 |
paulrobertlloyd
force-pushed
the
prototype-kit-dependency
branch
from
842ab00
to
373e205
Compare
paulrobertlloyd
force-pushed
the
prototype-kit-dependency
branch
from
373e205
to
487823d
Compare
|
Good point, let’s remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this is the right place this dependency should be listed (see: https://nodejs.org/en/blog/npm/peer-dependencies/)
Should hopefully fix x-govuk/govuk-eleventy-plugin#254.