Fix conditional content rendering bug #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a bit of a tricky one to trace as it doesn't manifest in plain Ruby (so wasn't caught by the specs and works preoprly in the guide) but does from ERB. Essentially, the refactor to remove duplication between fieldset radios and checkboxes (10fd3fb), while looking harmless, sets the `block.call` to a variable that's then captured, rather than capturing the `block.call` directly.
peteryates
added a commit
to DFE-Digital/get-into-teaching-app
that referenced
this pull request
Jun 8, 2021
Version 2.5.2 has a bug, outlined here: x-govuk/govuk-form-builder#288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit of a tricky one to trace as it doesn't manifest in plain Ruby (so wasn't caught by the specs and works properly in the guide) but does from ERB.
Essentially, the refactor to remove duplication between fieldset radios and checkboxes (10fd3fb), while looking harmless, sets the
block.callto a variable that's then captured, rather than capturing theblock.calldirectly. This caused the conditional content to be rendered outside of its wrapper.