Remove duplication between fieldset checkboxes and radios #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two classes act in a very-similar manner, much of the functionality is duplicate. As all fieldset items are conditional, we can safely remove the Traits::Conditional and just treat everything as a FieldsetItem. This is the same approach taken by the text fields and Traits::Input. Refs #283
peteryates
force-pushed
the
combine-conditional-radio-and-checkbox-functionality
branch
from
492e253
to
732e7e1
Compare
|
Thanks for suggesting this @jrmhaig, @jsugarman 👍🏽 |
peteryates
force-pushed
the
combine-conditional-radio-and-checkbox-functionality
branch
from
732e7e1
to
5231901
Compare
peteryates
deleted the
combine-conditional-radio-and-checkbox-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two classes act in a very-similar manner, much of the functionality is duplicate. As all fieldset items are conditional, we can safely remove the
Traits::Conditionaland just treat everything as aFieldsetItem.This is the same approach taken by the text fields and
Traits::Input.