Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We shouldn't split value strings, since deeper_merge will remove repeated words #279

Merged
merged 2 commits into from
May 13, 2021

Conversation

cpjmcquillan
Copy link
Collaborator

Problem

On Teaching Vacancies, schools can define a description, which we pre-fill in an About school input as part of our Create a job journey...

image

The eagle eyed user will notice some words are missing...

image

To be precise any repeated words (Case SenSitive) are missing... 😢

Solution

Stop splitting strings for value attributes, so that deeper_merge doesn't remove repeated words

Next steps

  • Perhaps we need to rethink how we split and merge custom attributes

@cpjmcquillan cpjmcquillan added the bug Something isn't working label May 13, 2021
@peteryates peteryates merged commit 4d9fabb into master May 13, 2021
@peteryates peteryates deleted the fix-value-bug branch May 13, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants