Small refactorings #248
Merged
Small refactorings #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteryates
force-pushed
the
small-refactorings
branch
from
01f05b0
to
e5e38fd
Compare
peteryates
force-pushed
the
small-refactorings
branch
from
e5e38fd
to
5d5dfb0
Compare
Instead add a #bound method to GOVUKDesignSystemFormBuilder::Base that returns them.
These aren't always hit by the tests for a reason and, as they're part of the test suite it doesn't make sense for them to count as untested.
The #buttons method is totally unnecessary here as @block_content will always be nil. Instead call #submit directly
peteryates
force-pushed
the
small-refactorings
branch
from
5d5dfb0
to
e9c9bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another batch of minor (mainly readability) improvements to the codebase. No functionality changes included.