Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_hidden argument to radios collection #227

Merged

Conversation

peteryates
Copy link
Member

@peteryates peteryates commented Dec 18, 2020

Rails has had this functionality since version 5 so it makes sense for it to be supported here. This change uses the same keyword, include_hidden, as Rails so should feel familiar to users. It's intended to allow forms to be submitted without any of the radios being selected.

Rails has had this functionality since version 5[0] so it makes sense
for it to be supported here. This change uses the same keyword,
include_hidden, as Rails so should feel familiar to users.

[0] rails/rails#18303
@peteryates peteryates added the enhancement New feature or request label Dec 18, 2020
Copy link

@ethax-ross ethax-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

@zheileman zheileman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@peteryates peteryates merged commit 6dbc053 into master Dec 18, 2020
@peteryates peteryates deleted the add-include-hidden-option-to-govuk-collection-radio-buttons branch December 18, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants