Allow suppression of elements by passing in nil #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteryates
force-pushed
the
allow-suppression-of-elements-via-nil
branch
2 times, most recently
from
b70d875
to
890e6ef
Compare
This addresses a problem where elements are always rendered if there's a matching localisation key, even if `nil` is supplied to the helper. Introducing a Elements::Null class simplifies the logic - an alternative solution was to introduce an :enabled flag but as we already have :active it was noisy and confusing. When the relevant argument (:caption, :hint, :label or :legend) is nil a Elements::Null is built instead of the usual 'active' element. It will never render any HTML and allows the suppression of elements. The default argument for captions, hints, labels and legends is always an empty hash, so simply not providing any arguments will allow the localisation mechanism to kick in and populate the element. Fixes #212
peteryates
force-pushed
the
allow-suppression-of-elements-via-nil
branch
from
890e6ef
to
c21ca33
Compare
cpjmcquillan
approved these changes
Nov 2, 2020
Hints can be added to fieldset items and should be suppressable in the same manner as regular helpers. A new field (stationery) was added to the spec objects for this to avoid clashes in existing tests. Refs #213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a problem where elements are always rendered if there's a matching localisation key, even if
nilis supplied to the helper.Introducing a
Elements::Nullclass simplifies the logic - an alternative solution was to introduce an:enabledflag but as we already have :active it was noisy and confusing.When the relevant argument (
:caption,:hint,:labelor:legend) is nil aElements::Nullis built instead of the usual 'active' element. It will never render any HTML and allows the suppression of elements.The default argument for captions, hints, labels and legends is always an empty hash, so simply not providing any arguments will allow the localisation mechanism to kick in and populate the element.
Fixes #212