fix: cross-platform clean script for Windows#45
Open
HJSTechnology wants to merge 1 commit into
Open
Conversation
Replace `rm -rf dist` with a Node fs.rmSync call so `npm run clean` (and the prebuild hook that depends on it) works on Windows where `rm` is unavailable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the Unix-only
rm -rf distin thecleannpm script with a cross-platform Nodefs.rmSynccall.cleanruns via theprebuildhook, so on Windows (wherermis unavailable) the build previously failed. This makesnpm run clean,npm run build, andnpm testwork on Windows, macOS, and Linux.Notes
🤖 Generated with Claude Code