[NUOPEN-294] Order journal mask numerically #5811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diebas
changed the title
diebas
force-pushed
the
nuopen-294/order-journal-masks-numerically
branch
2 times, most recently
from
3214b94 to
bcfe58b
Compare
joaquinco
approved these changes
Nov 14, 2025
diebas
force-pushed
the
nuopen-294/order-journal-masks-numerically
branch
from
bcfe58b to
63ef893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
When assigning the Journal mask to new facilities it was ordering the values alphabetically. That solution works great when there are less than 100 numbers. After 100, as 9 is alphabetically higher than 1, that order is still finding 99 as the last number so it tries to assign the C100 journal mask again and it fails.
Now we are ordering numerically so it always find the highest number value