[#137627] recently used products/facilities still works when no logged in user #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Do we want to add a spec that should have caught this? I feel like the link to the PR that caused it could be linked in the release notes. That way if we can essentially squash this note in our email notes if the guilty PR had not been released. |
giladshanan
approved these changes
Mar 19, 2018
Contributor
|
Adding a spec seems like a good idea to me. |
meara
changed the title
jhanggi
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Fix error on recently used products/facilities when there is no logged in user, follow up to #1429.
Additional Context
Error was occurring because we were trying to chain additional scopes onto
recently_used_facilitiesandrecently_used_productsinfacilities#index, which was an empty array rather than an empty AR relation when no user is present.