fix(types): include CSS entrypoints in PublicPath generation#2150
fix(types): include CSS entrypoints in PublicPath generation#2150aklinker1 merged 2 commits intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@dahomita But that's good idea to include all |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2150 +/- ##
==========================================
+ Coverage 76.08% 76.46% +0.38%
==========================================
Files 113 113
Lines 3048 3055 +7
Branches 682 686 +4
==========================================
+ Hits 2319 2336 +17
+ Misses 643 636 -7
+ Partials 86 83 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for helping make WXT better! |
Co-authored-by: Aaron <aaronklinker1@gmail.com>
Good question @PatrykKuniczak ! This PR only updates TypeScript path generation (PublicPath) so valid CSS output paths are typed correctly for |
|
@dahomita Yeah, i've forgot about |
Overview
I picked this up as a follow-up to the discussion in #2142.
The goal is to ensure
PublicPathtyping matches actual generated outputs by including CSS entrypoints, sobrowser.runtime.getURLtype checks are accurate for CSS assets as well as JS/HTML.This updates path generation to map:
content-script-style->.cssunlisted-style->.cssI also added an e2e test in
typescript-project.test.tsto assert CSS paths are present in generated.wxt/types/paths.d.ts(/plain.cssand/content-scripts/overlay.css).Manual Testing
pnpm testtemplates/vanillaby adding css entrypoints and confirming they were included inPublicPathRelated Issue
This PR closes #<issue_number>