Skip to content

fix: Make ExtensionRunner#closeBrowser optional #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aklinker1 merged 3 commits into from
Feb 9, 2026
Merged

fix: Make ExtensionRunner#closeBrowser optional #2092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da2af37
fix: Make `ExtensionRunner#closeBrowser` optional
aklinker1 Feb 8, 2026
90c5b45
fix types
aklinker1 Feb 8, 2026
1f352da
add coauthor
aklinker1 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/wxt/src/core/create-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ async function createServerInternal(): Promise<WxtDevServer> {
async stop() {
wasStopped = true;
keyboardShortcuts.stop();
await runner.closeBrowser();
await runner.closeBrowser?.();
await builderServer.close();
await wxt.hooks.callHook('server:closed', wxt, server);

Expand All @@ -150,7 +150,7 @@ async function createServerInternal(): Promise<WxtDevServer> {
server.ws.send('wxt:reload-extension');
},
async restartBrowser() {
await runner.closeBrowser();
await runner.closeBrowser?.();
keyboardShortcuts.stop();
await wxt.reloadConfig();
runner = await createExtensionRunner();
Expand Down
3 changes: 0 additions & 3 deletions packages/wxt/src/core/runners/manual.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,5 @@ export function createManualRunner(): ExtensionRunner {
)}" as an unpacked extension manually`,
);
},
async closeBrowser() {
// noop
},
};
}
3 changes: 0 additions & 3 deletions packages/wxt/src/core/runners/safari.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,5 @@ export function createSafariRunner(): ExtensionRunner {
)}" as an unpacked extension manually`,
);
},
async closeBrowser() {
// noop
},
};
}
3 changes: 0 additions & 3 deletions packages/wxt/src/core/runners/wsl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,5 @@ export function createWslRunner(): ExtensionRunner {
)}" as an unpacked extension manually`,
);
},
async closeBrowser() {
// noop
},
};
}
4 changes: 3 additions & 1 deletion packages/wxt/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,9 @@ export interface FsCache {

export interface ExtensionRunner {
openBrowser(): Promise<void>;
closeBrowser(): Promise<void>;

closeBrowser?(): Promise<void>;

/** Whether or not this runner actually opens the browser. */
canOpen?(): boolean;
}
Expand Down
Loading