feat!: new template variable {{versionName}} and change of the behaviour of {{version}}#1612
Open
Tensai75 wants to merge 2 commits intowxt-dev:majorfrom
Open
feat!: new template variable {{versionName}} and change of the behaviour of {{version}}#1612Tensai75 wants to merge 2 commits intowxt-dev:majorfrom
{{versionName}} and change of the behaviour of {{version}}#1612Tensai75 wants to merge 2 commits intowxt-dev:majorfrom
Conversation
…viour of `{{version}}`
BREAKING CHANGE: change the behaviour of the template variable `{{version}}` for artifactTemplate and sourcesTemplate to use `manifest.version` and add the new template variable `{{versionName}}` which uses `manifest.version_name` or, if not available, `manifest.version` and takes over the previous behaviour of `{{version}}`
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
{{versionName}} and change of the …{{versionName}} and change of the behaviour of {{version}}
aklinker1
previously approved these changes
Sep 3, 2025
Member
aklinker1
left a comment
There was a problem hiding this comment.
Changed the base to be merged into the next major branch. Not sure when I'll do another major release.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## major #1612 +/- ##
==========================================
- Coverage 80.98% 80.88% -0.11%
==========================================
Files 131 131
Lines 6679 6680 +1
Branches 1094 1092 -2
==========================================
- Hits 5409 5403 -6
- Misses 1259 1266 +7
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Wait, I still want the default behavior to be the same. So we should update the default templates to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: change the behaviour of the template variable
{{version}}for artifactTemplate and sourcesTemplate to usemanifest.versionand add the new template variable{{versionName}}which usesmanifest.version_nameor, if not available,manifest.versionand takes over the previous behaviour of{{version}}Overview
This PR is a continuation of PR #1604 and the associated discussion and introduces a breaking change to the behaviour of the template variable
{{version}}for artifactTemplate and sourcesTemplate. Currently{{version}}uses the version_name from the manifest or, if not available, the version from the manifest. This is unituitive and it is therefore suggested to change the behaviour to only use the version from the manifest and introduce a new template variable{{versionsName}}to take over the previous behaviour of{{version}}:{{version}}--> always usesmanifest.version{{versionsName}}--> usesmanifest. version_nameor fallback tomanifest.version{{packageVersion}}--> always uses the version from package.json (which is identical tomanifest.version_name) [introduced with PR feat: add{{packageVersion}}as template variable #1604]This gives the user more and consistent control over the version number used in the filename of generated zip files.
Manual Testing
package.jsonto1.0.0-beta.1wxt.config.ts, runwxt zipandwxt zip -b firefox{{name}}-{{version}}-{{browser}}.zipand{{name}}-{{version}}-sources.zip:wxt.config.ts:wxt zipandwxt zip -b firefoxand the resulting zip files should have the following names:wxt.config.tsto:wxt zipandwxt zip -b firefoxand the resulting zip files should have the following names:Related Issue
N/A
This breaking change was discussed in PR #1604