duplicates in #imports

[orangejuiceext]

Describe the bug

Hi there, I just noticed that I'm generating duplicates in the imports-module.d.ts file.

Thanks for a wonderful project! Keep up the awesome work.

Reproduction

The hint is that they all seem to be classes.

#2064 (comment)

Steps to reproduce

No response

System Info

latest wxt

Used Package Manager

bun

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[aklinker1]

I don't see any duplicates in your screenshot... please copy-paste the actual text into the issue instead of taking a screenshot of your code. That would make it easier for me to find the duplicates.

But since you didn't include a reproduction, I'm gonna close this. Here's a good blog post about why full reproductions are necessary: https://antfu.me/posts/why-reproductions-are-required

[orangejuiceext]

@aklinker1 The duplicates in the screenshot are highlighted text. Instead of just closing the issue right away, at least give me the chance to respond. I'm not trying to waste your time.

"ActivityTrail", "ProviderAdapter", "InjectAdapter", "ItemData"

In terms of reproduction, do you have a test for export class Foo {}?

[aklinker1]

duplicates in the screenshot are highlighted text

Haha 🤦 blind, my bad.

That said, I still would have closed it since you didn't include a reproduction like the issue template requires. Feel free to update the issue description and re-open once you have a reproduction you can share.

Read through the blog post I shared if you're not sure what a reproduction is.

[orangejuiceext]

I see now that you just depend on unimport. I'll go poking around there. Sorry for the trouble.

[aklinker1]

You're fine. Creating a minimal reproduction might help you narrow down if it's something in your project specifically that's causing the problem, if it's how WXT uses unimport, or if it's an upstream bug of unimport.

[orangejuiceext]

Quickly adding a console.log and looking at the output, it is super clear where the duplicates are coming from...

async function getImportsModuleEntry(wxt, unimport) {
  const imports = await unimport.getImports();
  console.log({ imports });
  return {
    path: "types/imports-module.d.ts",
    text: [
      "// Generated by wxt",
      "// Types for the #import virtual module",
      "declare module '#imports' {",
      `  ${toExports(imports, wxt.config.wxtDir, true).replaceAll("\n", "\n  ")}`,
      "}",
      ""
    ].join("\n"),
    tsReference: true
  };
}

  {
      name: 'ProvideAdapter',
      as: 'ProvideAdapter',
      from: '/Users/checkout/oj/OrangeJuice/src/utils/comctx-adapters.ts'
    },
    {
      name: 'ProvideAdapter',
      as: 'ProvideAdapter',
      from: '/Users/checkout/oj/OrangeJuice/src/utils/comctx-adapters.ts',
      type: true,
      declarationType: 'class'
    },
    {
      name: 'InjectAdapter',
      as: 'InjectAdapter',
      from: '/Users/checkout/oj/OrangeJuice/src/utils/comctx-adapters.ts'
    },
    {
      name: 'InjectAdapter',
      as: 'InjectAdapter',
      from: '/Users/checkout/oj/OrangeJuice/src/utils/comctx-adapters.ts',
      type: true,
      declarationType: 'class'
    },

[orangejuiceext]

Do you need me to do more reproduction work or is this enough now?

[aklinker1]

Give me a reproduction

[orangejuiceext]

export { Foo, Foo } from '../src/components/foo';

Unzip, bun install, wxt build, see above line at bottom of file.

duplicates.zip