Skip to content

Conversation

@jmoraleda
Copy link
Contributor

No description provided.

@swt2c
Copy link
Collaborator

swt2c commented Dec 16, 2025

Replaced by #2836. Sorry, couldn't figure out how to review a submodule update (and needed to update CI).

@swt2c swt2c closed this Dec 16, 2025
@jmoraleda
Copy link
Contributor Author

Hello Scott,

Thank you for taking care of this!

FYI, for future reference, until you mentioned it, I did not know how to review a submodule update, because indeed
https://github.com/wxWidgets/Phoenix/pull/2834/commits/1ea224e558e0858b2450214cb556c633c2f8b5a0

wants to show the actual changes in wxWidgets instead of simply the change in commit ids. But I have figured it out: Append .patch to the commit url gives us the raw diff of the commit, which shows the change you want to see:

https://github.com/wxWidgets/Phoenix/pull/2834/commits/1ea224e558e0858b2450214cb556c633c2f8b5a0.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants