StringUtils.cpp redefinition of "bool wxm::StartsWithChar" and "bool wxm::EndsWithChar"

[atoussaint76]

Upon compiling wxmaxima on a Linux From Scratch development release, I get the following errors:

/home/alain/maxima_compile/wxmaxima/src/StringUtils.cpp:73:8: erreur: redéfinition de « bool wxm::StartsWithChar(const wxString&, char) »
73 | bool StartsWithChar(const wxString &str, char ch) {
| ^~~~~~~~~~~~~~
/home/alain/maxima_compile/wxmaxima/src/StringUtils.cpp:69:8: note: « bool wxm::StartsWithChar(const wxString&, wxStringCharType) » précédemment défini ici
69 | bool StartsWithChar(const wxString &str, wxStringCharType ch) {
| ^~~~~~~~~~~~~~
/home/alain/maxima_compile/wxmaxima/src/StringUtils.cpp:85:8: erreur: redéfinition de « bool wxm::EndsWithChar(const wxString&, char) »
85 | bool EndsWithChar(const wxString &str, char ch) {
| ^~~~~~~~~~~~
/home/alain/maxima_compile/wxmaxima/src/StringUtils.cpp:81:8: note: « bool wxm::EndsWithChar(const wxString&, wxStringCharType) » précédemment défini ici
81 | bool EndsWithChar(const wxString &str, wxStringCharType ch) {
| ^~~~~~~~~~~~
make[2]: *** [src/CMakeFiles/wxmaxima.dir/build.make:446: src/CMakeFiles/wxmaxima.dir/StringUtils.cpp.o] Error 1

Excuse the French language error messages but even setting LC_ALL=en_CA.UTF-8 on the command line of cmake and make does not display the error messages in English. Basically, both "bool wxm::StartsWithChar" and "bool wxm::EndsWithChar" get redefined on lines 73 (previous definition on line 69) and 85 (previous definition on 81) in version 24.05.0

I don't know if this has to do with wxWidgets being compiled with utf-8 support (not enabled by default on my build but I did enable utf-8 support) or anything else but I did test 25.01.0, 24.11.0 and this one version 24.05.0. All of them fails.

[atoussaint76]

Addendum:

g++ version used is 14.2.0

[daute]

Are you sure, you are using wxWidgets with utf-8 support? What is the output of wx-config --list?
Building without unicode is not recommended by the wxWidgets team, why do you build it without unicode?
https://docs.wxwidgets.org/3.2/overview_unicode.html#overview_unicode_supportin

And all our CI compile jobs work without problems.

But when looking at the functions, they may be not necessary, I will check that...
Best regards, Wolfgang

[atoussaint76]

I do build with unicode:

alain [ ~ ]$ wx-config --list

Default config is gtk3-unicode-3.2

Default config will be used for output

Please excuse me if that was not clear previously because, IIRC, there were 2 options related to unicode: unicode support and unicode enabled by default. I did enable support for unicode, but I didn't enable unicode usage by default, leaving the choice to applications using it (wxmaxima in this case).

Thanks,
Alain

[daute]

I have removed the functions wxm::EndsWithChar() and wxm::EndsWithChar() now. Can you test, if the current git HEAD compiles on your machine?

[atoussaint76]

Built fine but then I'm getting core dump. See included file.

wxmaxima_runtime.txt

[daute]

Thanks. That issue was not easy to find. You probably used --enable-utf8=yes in your wxWidgets configuration (which is the 'internal representation' of strings in wxWidgets). I think I fixed the case, if one uses

 --enable-utf8=yes --enable-utf8only=yes

when configuring wxWidgets (and of course omitting both flags). There still is an issue with only the first ./configure option, but not the second.

Remark: The wxWidgets-team recommends:
"Generally speaking you should only use non-default UTF-8 build in specific circumstances"
https://docs.wxwidgets.org/3.2/overview_unicode.html#overview_unicode_support_utf
So maybe it makes sense, to just use the default?

[atoussaint76]

wxmaxima work as intended with those changes in wxWidgets. I did enable both flags to configure on my new build of wxWidgets.

The bug report can now be closed.

Thanks you very much,
Alain