Conversation
beem812
reviewed
Feb 5, 2020
| > | ||
| ) => void | ||
| ): ITypedQueryBuilder< | ||
| Model, |
There was a problem hiding this comment.
Edit for clarity:
On this and on other joins, this return type overrides any previous joins. By that I mean if I have a table A, and I join table B and then I join table C, when I go to select the columns I want I only have access to columns from table A and table C. This means if I want columns from all three tables I have to join to table B, select columns from it then join to table C and select columns from it. if the return type was ITypedQueryBuilder<Model, AddPropertyWithType<_SelectableModel, NewPropertyKey, NewPropertyType | null>, Row> all joined tables would be selectable when you got to choose what columns you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.