Skip to content

Commit

Permalink
fix(distro): exclude Hikari's SLF4J from standalone webapps
Browse files Browse the repository at this point in the history
- this pulled in SLF4J 2.0.0-alpha if built with Java 11 (not with Java 8)
- Our libraries are built and tested with SLF4J 1.7 so we should use that

related to CAM-13962
  • Loading branch information
ThorbenLindhauer committed Sep 24, 2021
1 parent 293902b commit f89f845
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions internal-dependencies/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,17 @@
<groupId>com.zaxxer</groupId>
<artifactId>HikariCP</artifactId>
<version>${version.hikaricp}</version>
<exclusions>
<!-- When building with Java 8, hikari has a dependency to SLF4j 1.7.
When building with Java 11 or higher, Hikari has a dependency to SLF4j
2.0.0-alpha1 instead. We are therefore excluding this dependency here
and assume that it comes from other dependencies where it is used
(for example camunda-commons-logging). -->
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>commons-logging</groupId>
Expand Down

0 comments on commit f89f845

Please sign in to comment.