Crashes loading presets containing certain effects

[Cal-Nine]

EasyEffects Version

8.0.6

What package are you using?

NixOS

Distribution

NixOS

Describe the bug

It seems like when I use the Convoluter plugin and maybe others in a preset, EasyEffects crashes when loading that preset. I am using the new dry/wet mix for convoluter, maybe that has something to do with it.

To fix, I go to ~/.config/easyeffects/db/ and delete everything there except easyeffectsrc, and it works for a while.

I am happy to test more and post a log when I have time, just wanted to post the bug straight away for the temporary fix.

Expected Behavior

No response

Debug Log

Debug Log

Paste your log here by launching with G_MESSAGES_DEBUG=easyeffects

Additional Information

No response

[wwmm]

Are you able to build a package from our master branch? I did some changes there that probably should fix this. Long story short when the convolver and the crystalizer were used together or there were multiple instances of one of them the library fftw used by zita-convolver could randomly crash. I've updated our master branch with additional protections for these cases. So far it is working on my side.

[Cal-Nine]

I was using multiple instances of convolver, so that sounds like the issue

[wwmm]

I was using multiple instances of convolver, would that do it?

Yes. For some reason the fftw library used by zita-convolver keeps some kind of global state that is shared by all fftw instances. And the moment we have multiple zita-convolver instances the fftw object created by one can delete fftw global state objects created by the other. And the application crashes.

The only way I found to avoid this is putting a global mutex shared by all convolver and crystalizer instances. It has fixed the issue so far. But is probably horrible for performance considering that all of this is in a realtime thread.