Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify desorption parameterization #46

Open
wwieder opened this issue Apr 6, 2021 · 3 comments
Open

Modify desorption parameterization #46

wwieder opened this issue Apr 6, 2021 · 3 comments
Assignees

Comments

@wwieder
Copy link
Owner

wwieder commented Apr 6, 2021

The desorption of SOMp to SOMa in MIMICS is defined as function of soil texture,
https://github.com/wwieder/biogeochem_testbed_1.1/blob/9988b1b70266f8aafd9877c55e656e52fc77798d/SOURCE_CODE/mimics_inout_CN.f90#L387
see also https://github.com/wwieder/biogeochem_testbed_1.1/blob/9988b1b70266f8aafd9877c55e656e52fc77798d/SOURCE_CODE/mimics_cycle_CN.f90#L888

This function should also depend on temperature (and eventually pH).

On air dried soils Kaiser et al. 2001 Geoderma doi:10.1016/S0016-7061(00)00077-X report increases in DOC released with temperature (intercept b in isotherms), corresponding to a Q10 of 1.1-1.6 for hydrophopic and hydrophilic DOC, respectively.

This is more broadly consistent with the onion model proposed by Kleber et al 2007 Biogeochemistry DOI: 10.1007/s10533-007-9103-5

Thus, let's add a line below this function
https://github.com/wwieder/biogeochem_testbed_1.1/blob/9988b1b70266f8aafd9877c55e656e52fc77798d/SOURCE_CODE/mimics_inout_CN.f90#L387
mimicsbiome%desorb(npt) = mimicsbiome%desorb(npt) *Q10_desorb^((SoilTemperature-25)/10)

Q10_desorb should also be on the parameter file, but for now I'll just use 1.5
Alternatively, we could wrap Q10_desorb into fSOM_p(3)
This also assumes soil temperatures are in C and uses 25 C as a reference temperature.

Down the road this should likely be a proper sorption isotherm with bi-direction exchange between SOMc and SOMa, but this is a good start...

@wwieder
Copy link
Owner Author

wwieder commented Apr 6, 2021

@melanniehartman while we're doing this can we correct the code so that desorption is spelled correctly (and the in question here changed to parameter desorp)? Sorry this was an error I made in the orig. MIMICS code...

@wwieder
Copy link
Owner Author

wwieder commented Apr 7, 2021

This seems pretty straightforward so I have a simple implementation that you can see here. @melanniehartman can you look to see if this is being done correctly?

A few notes:

  • I've only done it for the reverse model with C:N biogeochemistry.
  • I've started a spinup to assess impacts on global simulations.

If this looks OK we will have to:

  • Repeat this in in mimics_cycle.f90 to generate comparable C-only runs?
  • Move the Q10 values  (and reference temperature?) onto the parameter file. 

@piersond
Copy link

Would it be helpful to also add this change to sandbox? Perhaps we start a sandbox-dev branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants