-
Notifications
You must be signed in to change notification settings - Fork 69
Update airframe-rx-html, sbt-airframe to 2025.1.23 #4126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine update of the Highlights
π§ New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates airframe-rx-html and sbt-airframe dependencies to version 2025.1.23. The changes correctly update the version strings across multiple example projects. While the update is correct, I've identified a maintainability issue where the version number is duplicated in build.sbt and project/plugins.sbt for some examples. I've left comments with suggestions on how to centralize the version definition to make future updates easier and less error-prone.
| @@ -1,4 +1,4 @@ | |||
| val AIRFRAME_VERSION = "2025.1.22" | |||
| val AIRFRAME_VERSION = "2025.1.23" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this change is correct, I noticed that AIRFRAME_VERSION is defined here and also hardcoded in project/plugins.sbt. This duplication makes version updates error-prone.
To improve maintainability, I recommend defining the version in a single place. A common pattern in sbt is to use a Scala object in the project directory.
For example, you could create project/Dependencies.scala:
object V {
val Airframe = "2025.1.23"
}Then, you can reference this version in both build.sbt and project/plugins.sbt:
build.sbt:
val AIRFRAME_VERSION = V.Airframeproject/plugins.sbt:
addSbtPlugin("org.wvlet.airframe" % "sbt-airframe" % V.Airframe)This change would centralize the version string, making future updates simpler and safer.
| Global / onChangedBuildSource := ReloadOnSourceChanges | ||
|
|
||
| val AIRFRAME_VERSION = "2025.1.22" | ||
| val AIRFRAME_VERSION = "2025.1.23" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About this PR
π¦ Updates
from
2025.1.22to2025.1.23π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: