Skip to content

Conversation

@xerial-bot
Copy link
Collaborator

About this PR

πŸ“¦ Updates

from 2025.1.22 to 2025.1.23

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.wvlet.airframe" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.wvlet.airframe" }
}]
labels: library-update

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine update of the airframe-rx-html library and the sbt-airframe plugin to their latest stable version, 2025.1.23. This ensures the project benefits from the most recent features, bug fixes, and performance improvements provided by the Airframe ecosystem, maintaining compatibility and leveraging the newest developments.

Highlights

  • Dependency Update: The airframe-rx-html library and the sbt-airframe plugin have been updated from version 2025.1.22 to 2025.1.23 across various example projects.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates airframe-rx-html and sbt-airframe dependencies to version 2025.1.23. The changes correctly update the version strings across multiple example projects. While the update is correct, I've identified a maintainability issue where the version number is duplicated in build.sbt and project/plugins.sbt for some examples. I've left comments with suggestions on how to centralize the version definition to make future updates easier and less error-prone.

@@ -1,4 +1,4 @@
val AIRFRAME_VERSION = "2025.1.22"
val AIRFRAME_VERSION = "2025.1.23"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change is correct, I noticed that AIRFRAME_VERSION is defined here and also hardcoded in project/plugins.sbt. This duplication makes version updates error-prone.

To improve maintainability, I recommend defining the version in a single place. A common pattern in sbt is to use a Scala object in the project directory.

For example, you could create project/Dependencies.scala:

object V {
  val Airframe = "2025.1.23"
}

Then, you can reference this version in both build.sbt and project/plugins.sbt:

build.sbt:

val AIRFRAME_VERSION = V.Airframe

project/plugins.sbt:

addSbtPlugin("org.wvlet.airframe" % "sbt-airframe" % V.Airframe)

This change would centralize the version string, making future updates simpler and safer.

Global / onChangedBuildSource := ReloadOnSourceChanges

val AIRFRAME_VERSION = "2025.1.22"
val AIRFRAME_VERSION = "2025.1.23"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The AIRFRAME_VERSION is also duplicated in project/plugins.sbt for this example. As mentioned for the hello-rpc example, centralizing this version string in a single file (e.g., project/Dependencies.scala) would improve maintainability and make future updates less error-prone.

@xerial xerial merged commit 5359709 into main Jan 7, 2026
26 checks passed
@xerial xerial deleted the update/airframe-rx-html-2025.1.23 branch January 7, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants