KEYCLOAK-14106 Adding a role to a composite role does not work with k…

…cadm
wuwx · Jul 3, 2020 · 7fea677 · 7fea677
1 parent 7247734
commit 7fea677
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 16 deletions.
diff --git a/...li/admin-cli/src/main/java/org/keycloak/client/admin/cli/operations/ClientOperations.java b/...li/admin-cli/src/main/java/org/keycloak/client/admin/cli/operations/ClientOperations.java
@@ -24,6 +24,6 @@
 public class ClientOperations {
 
     public static String getIdFromClientId(String rootUrl, String realm, String auth, String clientId) {
-        return getIdForType(rootUrl, realm, auth, "clients", "clientId", clientId);
+        return getIdForType(rootUrl, realm, auth, "clients", "clientId", clientId, "clientId");
     }
 }
diff --git a/...cli/admin-cli/src/main/java/org/keycloak/client/admin/cli/operations/GroupOperations.java b/...cli/admin-cli/src/main/java/org/keycloak/client/admin/cli/operations/GroupOperations.java
@@ -29,11 +29,11 @@
 public class GroupOperations {
 
     public static String getIdFromName(String rootUrl, String realm, String auth, String groupname) {
-        return getIdForType(rootUrl, realm, auth, "groups", "name", groupname);
+        return getIdForType(rootUrl, realm, auth, "groups", "name", groupname, "name");
     }
 
     public static String getIdFromPath(String rootUrl, String realm, String auth, String path) {
-        return getIdForType(rootUrl, realm, auth, "groups", "path", path);
+        return getIdForType(rootUrl, realm, auth, "groups", "path", path, "path");
     }
 
     public static void addRealmRoles(String rootUrl, String realm, String auth, String groupid, List<?> roles) {

diff --git a/...-cli/admin-cli/src/main/java/org/keycloak/client/admin/cli/operations/RoleOperations.java b/...-cli/admin-cli/src/main/java/org/keycloak/client/admin/cli/operations/RoleOperations.java
@@ -38,7 +38,7 @@ public static class LIST_OF_ROLES extends ArrayList<RoleRepresentation>{};
     public static class LIST_OF_NODES extends ArrayList<ObjectNode>{};
 
     public static String getIdFromRoleName(String adminRoot, String realm, String auth, String rname) {
-        return getIdForType(adminRoot, realm, auth, "roles", "name", rname);
+        return getIdForType(adminRoot, realm, auth, "roles", "search", rname, "name");
     }
 
     public static void addRealmRoles(String rootUrl, String realm, String auth, String roleid, List<?> roles) {
@@ -60,11 +60,11 @@ public static void removeClientRoles(String rootUrl, String realm, String auth,
     }
 
     public static String getRoleNameFromId(String adminRoot, String realm, String auth, String rid) {
-        return getAttrForType(adminRoot, realm, auth, "roles", "id", rid, "name");
+        return getAttrForType(adminRoot, realm, auth, "roles", "id", rid, "id","name");
     }
 
     public static String getClientRoleNameFromId(String adminRoot, String realm, String auth, String cid, String rid) {
-        return getAttrForType(adminRoot, realm, auth, "clients/" + cid + "/roles", "id", rid, "name");
+        return getAttrForType(adminRoot, realm, auth, "clients/" + cid + "/roles", "id", rid, "id", "name");
     }
 
     public static List<RoleRepresentation> getRealmRoles(String rootUrl, String realm, String auth) {

diff --git a/...-cli/admin-cli/src/main/java/org/keycloak/client/admin/cli/operations/UserOperations.java b/...-cli/admin-cli/src/main/java/org/keycloak/client/admin/cli/operations/UserOperations.java
@@ -91,6 +91,6 @@ public static void resetUserPassword(String rootUrl, String realm, String auth,
     }
 
     public static String getIdFromUsername(String rootUrl, String realm, String auth, String username) {
-        return getIdForType(rootUrl, realm, auth, "users", "username", username);
+        return getIdForType(rootUrl, realm, auth, "users", "username", username, "username");
     }
 }
diff --git a/...ation/client-cli/admin-cli/src/main/java/org/keycloak/client/admin/cli/util/HttpUtil.java b/...ation/client-cli/admin-cli/src/main/java/org/keycloak/client/admin/cli/util/HttpUtil.java
@@ -434,25 +434,21 @@ public static void doDeleteJSON(String resourceUrl, String auth, Object content)
         checkSuccess(resourceUrl, response);
     }
 
-    public static String getIdForType(String rootUrl, String realm, String auth, String resourceEndpoint, String attrName, String attrValue) {
+    public static String getIdForType(String rootUrl, String realm, String auth, String resourceEndpoint, String attrName, String attrValue, String inputAttrName) {
 
-        return getAttrForType(rootUrl, realm, auth, resourceEndpoint, attrName, attrValue, "id");
+        return getAttrForType(rootUrl, realm, auth, resourceEndpoint, attrName, attrValue, inputAttrName, "id");
     }
 
-    public static String getAttrForType(String rootUrl, String realm, String auth, String resourceEndpoint, String attrName, String attrValue, String returnAttrName) {
+    public static String getAttrForType(String rootUrl, String realm, String auth, String resourceEndpoint, String attrName, String attrValue, String inputAttrName, String returnAttrName) {
 
         String resourceUrl = composeResourceUrl(rootUrl, realm, resourceEndpoint);
-        if ("roles".equals(resourceEndpoint)) {
-            resourceUrl = HttpUtil.addQueryParamsToUri(resourceUrl, "search", attrValue, "first", "0", "max", "2");
-        } else {
-            resourceUrl = HttpUtil.addQueryParamsToUri(resourceUrl, attrName, attrValue, "first", "0", "max", "2");
-        }
+        resourceUrl = HttpUtil.addQueryParamsToUri(resourceUrl, attrName, attrValue, "first", "0", "max", "2");
 
         List<ObjectNode> users = doGetJSON(RoleOperations.LIST_OF_NODES.class, resourceUrl, auth);
 
         ObjectNode user;
         try {
-            user = new LocalSearch(users).exactMatchOne(attrValue, attrName);
+            user = new LocalSearch(users).exactMatchOne(attrValue, inputAttrName);
         } catch (Exception e) {
             throw new RuntimeException("Multiple " + resourceEndpoint + " found for " + attrName + ": " + attrValue, e);
         }