Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync to prevent down-kafka.sh from being busy #261

Merged
merged 1 commit into from
Mar 18, 2018

Conversation

z4f1r0v
Copy link
Contributor

@z4f1r0v z4f1r0v commented Feb 8, 2018

This PR reintroduces the sync step that #138 added. It helps to run the docker-compose -f docker-compose-single-broker.yml up command.

@z4f1r0v
Copy link
Contributor Author

z4f1r0v commented Feb 15, 2018

Can some of the maintainers look at this, please? @wurstmeister

@sscaling
Copy link
Collaborator

@sscaling
Copy link
Collaborator

sscaling commented Mar 17, 2018

Hi @alexanderzafirov - thanks for the PR. This issue only seems to occur on some configurations. Could you provide some more information on your environment so we can try and document this? i.e. docker version && OS version.

We can then at least add a comment to the dockerfile so this doesn't get inadvertently removed again.

@sscaling sscaling self-requested a review March 17, 2018 19:43
@wurstmeister wurstmeister merged commit ac3e950 into wurstmeister:master Mar 18, 2018
@wurstmeister
Copy link
Owner

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants