Update the Dockerfile to work on Windows machines #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 13, 2017 16:52
|
I understand that there is a setting on git that allows the checkouts (and checkins) to keep linux line endings, but that would require a check in for testing, and/or only pulling with no editing. I think this is a great way to work around people using windows to edit / add files, and give them the template to add more scripts. I leave for reference this article which basically says: "Yeah, it kinda sucks but this is the best work around still" http://willi.am/blog/2016/08/11/docker-for-windows-dealing-with-windows-line-endings/ |
|
Fixes #146 |
|
Potentially fixes #262 |
|
Not working for me. Using Windows 10. I clone this repo and change the Dockerfile based on @auggiecc87 fix but it is not working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively simple change to allow people using windows to not get hosed when they pull this repo (I know, "but why are you using windows?", maybe because that is what my company uses).