Skip to content

Commit

Permalink
Merge pull request BabylonJS#10935 from SahilTara/Performance-Graph-S…
Browse files Browse the repository at this point in the history
…cene-Extension-Visible

Made getPerfCollector method public in Scene class
  • Loading branch information
RaananW authored Aug 27, 2021
2 parents 2c0c03f + 070cd0f commit 2933d2d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export const PerformanceViewerComponent: React.FC<IPerformanceViewerComponentPro
}

useEffect(() => {
const perfCollector = scene._getPerfCollector();
const perfCollector = scene.getPerfCollector();
perfCollector.addCollectionStrategies(...defaultStrategies);
setPerformanceCollector(perfCollector);
}, []);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Scene } from "../../scene";
import { PerformanceViewerCollector } from "./performanceViewerCollector";

Scene.prototype._getPerfCollector = function(this: Scene): PerformanceViewerCollector {
Scene.prototype.getPerfCollector = function(this: Scene): PerformanceViewerCollector {
if (!this._perfCollector) {
this._perfCollector = new PerformanceViewerCollector(this);
}
Expand Down
7 changes: 5 additions & 2 deletions src/scene.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5212,8 +5212,11 @@ export class Scene extends AbstractScene implements IAnimatable, IClipPlanesHold
*/
protected _perfCollector: Nullable<PerformanceViewerCollector> = null;

/** @hidden */
public _getPerfCollector(): PerformanceViewerCollector {
/**
* This method gets the performance collector belonging to the scene, which is generally shared with the inspector.
* @returns the perf collector belonging to the scene.
*/
public getPerfCollector(): PerformanceViewerCollector {
throw _DevTools.WarnImport("performanceViewerSceneExtension");
}

Expand Down

0 comments on commit 2933d2d

Please sign in to comment.