Skip to content

SLT-1193: Update Silta configuration to use mailpit instead of mailhog #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

k4lv15
Copy link

@k4lv15 k4lv15 commented May 20, 2025

Ticket SLT-1193

Changes

  • Update Silta configuration to use mailpit instead of mailhog as last is deprecated and will be removed from Drupal chart in future. Mailpit is already configured for lando (also DDEV?), it makes sense to do that for Silta as well!

Testing

Enviroment: https://feature-slt-1193-mail.drupal-project.dev.wdr.io

Instructions:
Test mail functionality, i.e.:

  1. Create a new account at https://feature-slt-1193-mail.drupal-project.dev.wdr.io/user/register
  2. Go to https://feature-slt-1193-mail.drupal-project.dev.wdr.io/mailpit/, see that user registrations email messages are there

@k4lv15 k4lv15 requested a review from Copilot May 20, 2025 08:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the deprecated MailHog configuration with Mailpit in both non-production and production Silta settings.

  • Swap mailhog blocks to mailpit in silta.yml (non-prod) and silta-prod.yml (prod)
  • Update associated comments to reference Mailpit instead of MailHog

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
silta/silta.yml Enable mailpit in non-production environments
silta/silta-prod.yml Disable mailpit in production environments
Comments suppressed due to low confidence (2)

silta/silta.yml:21

  • Indentation for the mailpit: key appears incorrect—ensure it aligns with other top-level keys and that its enabled property is indented consistently (e.g., two spaces under mailpit:).
mailpit:

silta/silta-prod.yml:57

  • Indentation for the mailpit: key appears incorrect—ensure it aligns with other top-level keys and that its enabled property is indented consistently (e.g., two spaces under mailpit:).
mailpit:

@k4lv15 k4lv15 requested review from tormi, misterjoonas and hkirsman May 20, 2025 08:35
Copy link
Member

@misterjoonas misterjoonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants