Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/emulsify linting setup #111

Merged
merged 26 commits into from
Sep 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
bc61dcc
Install the linting related npm packages from Emulsify
May 8, 2020
68922fe
Copy eslintrc from Emulsify
May 8, 2020
ac8239a
Copy prettier config from Emulsify
May 8, 2020
cddf985
Copy stylelintrc from Emulsify
May 8, 2020
56e2789
Install eslint-plugin-jsx-a11y and eslint-plugin-react as a quick fix…
May 29, 2020
a5ba92c
Remove unnecessary eslint configs
May 29, 2020
61471ef
prettier config newline
May 29, 2020
58e68de
Remove React related packages
Jun 15, 2020
727a809
Extend airbnb/base instead of airbnb in listing config
Jun 15, 2020
53c708d
Use JSON format for all the linting configuration files
Jun 15, 2020
c0d5d48
NPM security update
dbruvers Jul 20, 2020
2c1e7e1
Add back build command. List linting modules as peer dependecies
dbruvers Jul 20, 2020
51aa39d
Rename config files: add `.json` extension
dbruvers Jul 20, 2020
8679127
Mark ESLint's config as the root config
dbruvers Jul 20, 2020
9ffd49f
Run linting with root level config only
dbruvers Jul 24, 2020
5ace86c
Do not return errors on unmatched patterns
dbruvers Aug 7, 2020
f1baa43
Remove unneeded ESlint ignore file
dbruvers Aug 7, 2020
6dfd63f
Run Style lint against custom themes and modules
dbruvers Aug 7, 2020
1858bce
Fix typo
dbruvers Aug 7, 2020
16b685a
Add ESLint ignore file with commonly ignored paths
dbruvers Aug 28, 2020
0a19530
Do not ignore nested ESLint config
dbruvers Aug 28, 2020
05a4c2f
Add ESLint plugin packages required by Drupal core
dbruvers Aug 28, 2020
07afd80
Install stylelint-prettier npm package
Sep 9, 2020
f5329bb
run prettier as a stylelint rule via stylelint-prettier plugin
Sep 9, 2020
1c3d1ed
Fix stylelint linting paths
Sep 9, 2020
3dc49bb
Add Jest to ESlints environment configs
Sep 23, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
node_modules/
dist/
*.min.js
*.bundle.js
21 changes: 21 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"extends": [
"airbnb",
"prettier",
"plugin:prettier/recommended"
],
"plugins": ["prettier"],
"root": true,
"env": {
"es6": true,
"browser": true,
"jest": true
},
"globals": {
"Drupal": true
},
"rules": {
"strict": 0,
"prettier/prettier": "error"
}
}
4 changes: 4 additions & 0 deletions .prettierrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"singleQuote": true,
"trailingComma": "all"
}
26 changes: 26 additions & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"extends": [
"stylelint-config-standard",
"stylelint-config-prettier"
],
"plugins": ["stylelint-prettier"],
"rules": {
"at-rule-no-unknown": [ true, {
"ignoreAtRules": [
"include",
"mixin",
"extend",
"if",
"else",
"each",
"content",
"import",
"function",
"return"
]
}],
"no-descending-specificity": null,
"function-calc-no-invalid": null,
"prettier/prettier": true
}
}
Loading