SLT-1193: Add deprecation warning for mailhog in release notes #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a deprecation notice for the Mailhog service in the Helm chart’s user-facing notes and points users to the Mailpit alternative.
- Introduces a warning in
NOTES.txtindicating Mailhog deprecation and recommending Mailpit - Adds a link to updated Silta documentation for sending e-mail
Comments suppressed due to low confidence (1)
charts/drupal/templates/NOTES.txt:27
- Use consistent capitalization for product names. Change
mailhogtoMailhogand consider rephrasing to avoid repetition, e.g., “⚠️ DEPRECATED Mailhog will be removed in a future release; please use Mailpit instead.”
⚠️ **DEPRECATED** mailhog is deprecated and will be removed in the future, use mailpit instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
helm install --dry-run test-drupal ./charts/drupal --set mailhog.enabled=true