Improve handling of the _installing file #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4lv15
requested changes
Jun 4, 2025
|
|
||
| # Attempt to remove the _installing file at the very beginning, ignoring errors if it doesn't exist. | ||
| # This cleans up state from a potential previous failed install run. | ||
| rm -f "$INSTALLING_FILE" |
There was a problem hiding this comment.
Should we add || true also here to prevent potential erroring out? :)
There was a problem hiding this comment.
@k4lv15 the -f takes care of that, it does not fail even if the file does not exist :)
There was a problem hiding this comment.
Ahh, okays, just noticed it's added in the other place: https://github.com/wunderio/drupal-project-k8s/pull/747/files#diff-c4f491ae4ef2d83e98019bc3ac28e9ba383d1ec3573c7f25e65e1871f0f13821R436
Was wondering if we need it here as well. If not, all good then!
k4lv15
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the handling of the
_installingfile in thecharts/drupal/templates/_helpers.tplfile to improve maintainability and ensure consistent behavior across multiple commands. The changes centralize the definition of the_installingfile path, replace hardcoded paths with a reusable template, and add safeguards for file removal operations.Motivation
rmcommand errors out and fails the whole deploymentRefactoring
_installingFile Handling:drupal.installing-fileto centralize the definition of the_installingfile path, replacing hardcoded paths throughout the file.drupal.installation-in-progress-testdefinition to use the newdrupal.installing-filetemplate for consistency.Improvements to File Operations:
_installingfile at the beginning of thedrupal.data-pull-commandanddrupal.post-release-commanddefinitions, ignoring errors if the file does not exist, to clean up state from potential previous failed runs. [1] [2]rmandtouchoperations with variables referencing thedrupal.installing-filetemplate for better maintainability and readability. [1] [2] [3]