-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/slt 122 custngx #12
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ready for review |
The final changes look good, but it would be best to consolidate all the commits that lead there. @gatis could you do an interactive rebase to combine them? |
gatis
force-pushed
the
feature/SLT-122-custngx
branch
from
September 25, 2018 07:20
42be4cb
to
24ead26
Compare
…t be a great idea.
…nstall to regular job that gets removed after successful deployment.
gatis
force-pushed
the
feature/SLT-122-custngx
branch
from
September 25, 2018 07:28
24ead26
to
878dfc0
Compare
…m post-install to regular job that gets removed after successful deployment." This reverts commit 878dfc0.
…P too" This reverts commit f54a903.
…s. We don't need it yet." This reverts commit b8e3aff.
This reverts commit 2393bb0.
This reverts commit fb7245f.
…might not be a great idea." This reverts commit a5e7d97.
This reverts commit dcffbd9.
…ithin web folder" This reverts commit 9e750f5.
…otstrap fails." This reverts commit f99e3de.
…port;" This reverts commit a52af67.
This reverts commit 0617664.
moved to clean branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled the use of custom, semantically versioned images for php and nginx.
Code related to creating those images moved to separate repos.