#91. Changed finder constraint #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkirsman
force-pushed
the
feature/#91-finder-version
branch
2 times, most recently
from
db8e121 to
dd54508
Compare
hkirsman
force-pushed
the
feature/#91-finder-version
branch
from
dd54508 to
d314e0c
Compare
hkirsman
reviewed
Mar 31, 2023
| @@ -3,7 +3,7 @@ jobs: | |||
| # Install all dependencies and run check tasks. | |||
| build_and_test: | |||
| docker: | |||
| - image: circleci/php:8.0-cli-node | |||
| - image: cimg/php:8.1 | |||
There was a problem hiding this comment.
Seems we just needed to update to newer PHP as I think it was here in Finder library where it failed
$this->dirs = array_merge($this->dirs, ...$resolvedDirs);
circleci/php is deprecated so moving to cimg/php ( https://circleci.com/developer/images/image/cimg/php )
There was no cli tag and node is not needed. At least I don't know why it would be needed.
hkirsman
reviewed
Mar 31, 2023
| @@ -189,7 +189,7 @@ public function testHandlesParallelProcess(): void { | |||
| $this->process | |||
| ->expects($this->exactly(2)) | |||
| ->method('isRunning') | |||
| ->willReturnOnConsecutiveCalls([TRUE, FALSE]); | |||
| ->willReturnOnConsecutiveCalls(TRUE, FALSE); | |||
There was a problem hiding this comment.
isRunning() method should be returning boolean, but this was mocking it so that it would return array of those booleans. In older version is seemed to have worked or fail silently, but in newer version of Symfony it has return type defined so it failed:
hkirsman
approved these changes
Mar 31, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for D10 and symfony/finder version #91