Feature/#59 support drupal 8 and composer 2 #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormi
reviewed
Jun 7, 2021
| "drupal/coder": "^8", | ||
| "phpcompatibility/php-compatibility": "^9.3", | ||
| "pheromone/phpcs-security-audit": "^2.0", | ||
| "wunderio/ecs-drupal": "^1.0", | ||
| "symplify/coding-standard": "^8.3", | ||
| "wunderio/ecs-drupal": "^0.2.0", |
There was a problem hiding this comment.
Is this even needed as we also have mglaman/phpstan-drupal? ;)
There was a problem hiding this comment.
I don't see that being pulled in from https://github.com/mglaman/phpstan-drupal/blob/master/composer.json
Need to test what happens if removed.
There was a problem hiding this comment.
Pretty sure it's needed in 1.x as it was there before https://github.com/wunderio/code-quality/blob/bef94aaa1ecf3a220628bb2e932bc03779d26d8c/composer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give it a go on project with Drupal 8 and Composer 2