-
Couldn't load subscription status.
- Fork 12
SLT-1103: Add mailpit support for drupal and frontend charts #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t' when defining drupal.env as otherwise mailpit deployment has incorrect name and kubernetes services are not created.
…P_ADDRESS to <release-name>-mailpit-smtp:25 as that's the service/port that mailpit creates for SMTP communications.
…erwise secret is not created and php containers fail to start.
…xy /mailpit path to mailpit-http service.
…mails are not going through otherwise.
…ate Drupal's nginx config to proxy mailpit-http under Drupal's /mailpit path.
…g properly, adjust varnish rules.
…check that verifies mailpit and mailhog are not enabled at the same time. Add deprecation notes for mailhog.
…, update checks.yaml
…le service links.
71c8094 to
aefe001
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 19 out of 24 changed files in this pull request and generated no comments.
Files not reviewed (5)
- drupal/templates/NOTES.txt: Language not supported
- drupal/templates/_helpers.tpl: Language not supported
- drupal/values.schema.json: Language not supported
- frontend/templates/NOTES.txt: Language not supported
- frontend/templates/_helpers.tpl: Language not supported
Comments suppressed due to low confidence (1)
drupal/values.yaml:757
- The nested 'mailpit' block within the parent 'mailpit' configuration may be confusing. Consider renaming this nested key (e.g., to 'config' or 'proxy') to clarify its purpose.
mailpit:
Rade333
approved these changes
May 5, 2025
This was referenced May 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drupal chart: wunderio/drupal-project-k8s#741
Frontend chart: wunderio/frontend-project-k8s#141