playground: Change to use stdlib embed instead of packr #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvormste
referenced
this pull request
in TykTechnologies/graphql-go-tools
Apr 12, 2022
pvormste
referenced
this pull request
in TykTechnologies/graphql-go-tools
Apr 12, 2022
buraksezer
referenced
this pull request
in TykTechnologies/graphql-go-tools
Apr 13, 2022
…into feat/TT-4370/implement-kafka-data-source * 'master' of github.com:TykTechnologies/graphql-go-tools: playground: Change to use stdlib embed instead of packr (#360) update to go 1.16 Bump url-parse from 1.5.1 to 1.5.10 in /examples/chat (#352) Bump follow-redirects from 1.14.1 to 1.14.9 in /examples/chat (#351) implement renaming response typenames (#355) fix OnTypeName resolve panic (#350) disable resolve field positions for cleaner tests (#348)
|
This PR left the go generate in here: |
devsergiy
pushed a commit
that referenced
this pull request
Feb 25, 2025
This pull request will remove the obsolete packr generate directive so that folks will have an easier time contributing to this repository since they won't need to have packr installed locally. This is a follow-up to #360 where it got missed. Signed-off-by: Steve Coffman <steve@khanacademy.org> Signed-off-by: Steve Coffman <steve@khanacademy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the playground package embedding to use the stdlib embed vs using a third party tool (packr).
Fixes #359