chore: add deep tests for list value validation

[ysmolski]

Summary by CodeRabbit

• Tests
  • Expanded test coverage for variable type compatibility with deeply nested input object fields.
  • Added new test cases for complex nested list types, including triple-nested and ten-level nested lists, to ensure correct handling of nullability and nesting distinctions.

Checklist

• I have discussed my proposed changes in an issue and have received approval to proceed.
• I have followed the coding standards of the project.
• Tests or benchmarks have been added or updated.

[coderabbitai]

Walkthrough

The test suite for variable type compatibility in nested input object fields was expanded by introducing two new deeply nested input types and corresponding query fields in the GraphQL schema. Additional test cases were added to validate variable type compatibility for these complex nested list structures, focusing on various combinations of list nesting and nullability.

Changes

Files/Paths	Change Summary
v2/pkg/astvalidation/operation_validation_test.go	Added Input5 and Input10 input types and nested5, nested10 query fields; extended test cases for variable type compatibility with complex nested lists and nullability.

Estimated code review effort

2 (~15 minutes)

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 891d8b3 and 1de783f.

📒 Files selected for processing (1)

• v2/pkg/astvalidation/operation_validation_test.go (3 hunks)

🔇 Additional comments (3)

v2/pkg/astvalidation/operation_validation_test.go (3)

4028-4029: LGTM! Schema additions follow existing patterns.

The new query fields nested5 and nested10 are consistent with the existing schema structure and naming conventions.

---

4048-4052: Excellent test coverage for complex list validation scenarios.

The new input types provide comprehensive coverage:

• Input5 tests complex nullability patterns with triple-nested lists
• Input10 tests extreme nesting depth (10 levels) for validation edge cases

Both definitions are syntactically correct and follow the established patterns.

---

4134-4176: Comprehensive test coverage for complex nested list validation.

The test cases provide excellent coverage for variable type compatibility with deeply nested lists:

Input5 tests ([[[String]!]!]):

• Correctly validates both compatible and incompatible nullability patterns
• Proper error message validation for each invalid scenario
• Covers edge cases like middle-level nullability mismatches

Input10 tests ([[[[[[[[[[String]]]]]]]]]]]):

• Tests extreme nesting depth (10 levels) validation
• Validates compatibility with various nullability combinations at different nesting levels

The test structure follows established patterns and GraphQL variable compatibility rules correctly.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch yury/eng-6527-values-validation-logic-could-potentially-be-incorrect-on

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.