-
Notifications
You must be signed in to change notification settings - Fork 156
feat: pass in response body #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass in response body #1203
Conversation
WalkthroughThe Changes
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
v2/pkg/engine/resolve/loader.go (1)
58-60: Potential memory-/privacy bloat: copying entire response into an immutablestring
ResponseBodyduplicates the whole sub-graph payload (bytes.Buffer → string).
On large responses this might incur a noticeable extra allocation & GC pressure and, depending on what your LoaderHooks do, may accidentally leak PII if the struct is simply logged.If you only need the body for debugging/metrics consider:
- keeping it as
[]byteand letting hooks opt-in to a copy (clone()),- or truncating / redacting the payload before assigning.
Not blocking, but worth evaluating usage patterns.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
v2/pkg/engine/resolve/loader.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Build and test (go 1.23 / windows-latest)
- GitHub Check: Build and test (go 1.23 / windows-latest)
- GitHub Check: Linters
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.196](v2.0.0-rc.195...v2.0.0-rc.196) (2025-07-02) ### Features * pass in response body ([#1203](#1203)) ([ef03374](ef03374)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added the ability to pass in a response body. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary by CodeRabbit
For wundergraph/cosmo#2004
Checklist